Skip to content

StructType node update #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2024
Merged

StructType node update #2743

merged 6 commits into from
Jun 22, 2024

Conversation

tanay-man
Copy link
Contributor

Updated the ASR node StructType from

StructType(symbol derived_type)

to

StructType(ttype* data_member_types, ttype* member_function_types, bool is_cstruct, symbol derived_type)

@tanay-man
Copy link
Contributor Author

I have created a wrapper function for creation of StructType. It currently only considers cstyle structs. To add function defs, we need a parameter member_functions like members in the Struct symbol.
@certik @Thirumalai-Shaktivel

Thirumalai-Shaktivel
Thirumalai-Shaktivel approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!
LGTM.

certik
certik approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! Thank you.

@tanay-man
Copy link
Contributor Author

@Thirumalai-Shaktivel @certik , I have removed the comments.

@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit 546777e into lcompilers:main Jun 22, 2024
@tanay-man tanay-man deleted the struct-node-update branch July 6, 2024 11:24
@kmr-srbh kmr-srbh mentioned this pull request Aug 5, 2024
Closed
@tanay-man tanay-man mentioned this pull request Aug 9, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanay-man @certik @Thirumalai-Shaktivel